nixos/hydra: use runuser like hydra flake

[SuperSandro2000]

Description of changes

NixOS/hydra#1226

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.11 Release Notes (or backporting 22.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[SuperSandro2000]

/nix/store/nw5ll1l8d2a71fndywq7ry7a4nx4q2ab-unit-script-hydra-init-pre-start/bin/hydra-init-pre-start: line 25: runuser: command not foun

Not sure how that in hydra flake is supposed to work.

[dasJ]

It's ${pkgs.util-linux}/bin/runuser

[SuperSandro2000]

Testing on my hydra and works like a charm.

[mikepurvis]

Broken for me with runuser 2.37.4:

Jul 18 17:28:23 prod-vm-hydra-02 systemd[1]: Starting hydra-init.service...
Jul 18 17:28:23 prod-vm-hydra-02 hydra-init-pre-start[108517]: chown: warning: '.' should be ':': ‘hydra-queue-runner.hydra’
Jul 18 17:28:23 prod-vm-hydra-02 runuser[108518]: pam_unix(runuser:session): session opened for user postgres(uid=71) by (uid=0)
Jul 18 17:28:23 prod-vm-hydra-02 runuser[108518]: pam_unix(runuser:session): session closed for user postgres
Jul 18 17:28:23 prod-vm-hydra-02 hydra-init-pre-start[108521]: runuser: invalid option -- 'O'
Jul 18 17:28:23 prod-vm-hydra-02 hydra-init-pre-start[108521]: Try 'runuser --help' for more information.
Jul 18 17:28:23 prod-vm-hydra-02 systemd[1]: hydra-init.service: Control process exited, code=exited, status=1/FAILURE
Jul 18 17:28:23 prod-vm-hydra-02 systemd[1]: hydra-init.service: Failed with result 'exit-code'.
Jul 18 17:28:23 prod-vm-hydra-02 systemd[1]: Failed to start hydra-init.service.
warning: error(s) occurred while switching to the new configuration

Looks like it's missing a -- to ensure that the -O flag is passed to the postgres command rather than to runuser itself.

[SuperSandro2000]

Can you check if #182713 works for you?

[mikepurvis]

Yes, that LGTM.

On Sun, Jul 24, 2022 at 12:06 PM Sandro ***@***.***> wrote: Can you check if #182713 <#182713> works for you? — Reply to this email directly, view it on GitHub <#180536 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHGUGUIW3GWZJQI577WTK3VVVSXHANCNFSM525TDXLA> . You are receiving this because you commented.Message ID: ***@***.***>

-- http://uwmike.com