source-{sans,serif}-pro: reintroduce older font versions #163619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently, Source Sans/Serif Pro fonts got renamed. The "Pro" suffix was replaced with the major version of the font name. In the case of Source Serif, the change was announced in adobe-fonts/source-serif#77 and besides the name font metric have been changed too. Therefore, documents using the old "Pro" version might look differently when the font is changed to the new "4" version. In the case of Source Sans, the metrics seem not to have been changed (adobe-fonts/source-sans#192), but this comment (adobe-fonts/source-sans#192 (comment)) suggests that it might happen in the future. Due to the above, it makes sense to keep both old "Pro" and new (numbered) fonts as separate packages. This commit reintroduced the old "Pro" versions. It seems that Arch Linux is also distributing both versions: https://github.com/archlinux/svntogit-packages/blob/0d70461e5a26cde02cadfda64078eb93192c6caa/trunk/PKGBUILD Closes NixOS#157972
ofborg
bot
added
8.has: package (new)
ttuegel
approved these changes
Mar 11, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Recently, Source Sans/Serif Pro fonts got renamed. The "Pro" suffix was replaced with the major version of the font name.
In the case of Source Serif, the change was announced in adobe-fonts/source-serif#77 and besides the name font metric have been changed too. Therefore, documents using the old "Pro" version might look differently when the font is changed to the new "4" version.
In the case of Source Sans, the metrics seem not to have been changed, but this comment suggests that it might happen in the future.
Due to the above, it makes sense to keep both old "Pro" and new (numbered) fonts as separate packages. This commit reintroduces the old "Pro" versions.
It seems that Arch Linux is also distributing both versions: https://github.com/archlinux/svntogit-packages/blob/0d70461e5a26cde02cadfda64078eb93192c6caa/trunk/PKGBUILD
Closes #157972
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes