Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pantheon.switchboard-plug-onlineaccounts: 6.2.1 -> 6.2.2 #147445

Merged
merged 1 commit into from
Nov 26, 2021
Merged

pantheon.switchboard-plug-onlineaccounts: 6.2.1 -> 6.2.2 #147445

merged 1 commit into from
Nov 26, 2021

Conversation

bobby285271
Copy link
Member

@bobby285271 bobby285271 commented Nov 26, 2021 •
edited
Loading

Motivation for this change

Part of Pantheon 6.0.4 updates (previous one at #147256).

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: pantheon The Pantheon desktop environment label Nov 26, 2021
@bobby285271
Copy link
Member Author

bobby285271 commented Nov 26, 2021 •
edited
Loading

The following content is machine generated and may contain invalid information.

pantheon.switchboard-plug-onlineaccounts: 6.2.1 -> 6.2.2

Comment

I did some cleanup, many inputs are already not needed since #130380.

To inspect upstream changes

@bobby285271
Copy link
Member Author

bobby285271 commented Nov 26, 2021 •
edited
Loading

@ofborg test pantheon

@ofborg ofborg bot requested a review from davidak November 26, 2021 01:41
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Nov 26, 2021
@bobby285271
Copy link
Member Author

Result of nixpkgs-review pr 147445 run on x86_64-linux 1

5 packages built:
  • pantheon.elementary-greeter
  • pantheon.switchboard-plug-onlineaccounts
  • pantheon.switchboard-with-plugs
  • pantheon.wingpanel-applications-menu
  • pantheon.wingpanel-with-indicators

@bobby285271 bobby285271 marked this pull request as ready for review November 26, 2021 02:35
@bobby285271 bobby285271 added 9.needs: port to stable A PR needs a backport to the stable release. 8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. labels Nov 26, 2021
@bobby285271 bobby285271 merged commit 0f13759 into NixOS:master Nov 26, 2021
@bobby285271 bobby285271 deleted the pantheon branch November 26, 2021 06:31
@bobby285271 bobby285271 mentioned this pull request Nov 26, 2021
Merged
13 tasks
@bobby285271 bobby285271 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Nov 27, 2021
@bobby285271 bobby285271 mentioned this pull request Nov 30, 2021
Merged
13 tasks
davidak
davidak reviewed Dec 1, 2021
View reviewed changes
Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick review looks good. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidak davidak davidak left review comments

Assignees
No one assigned
Labels
6.topic: pantheon The Pantheon desktop environment 8.has: port to stable A PR already has a backport to the stable release. 8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bobby285271 @davidak