Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pantheon.gala: fix session crash when taking screenshots with mutter 3.38 #139491

Merged
merged 1 commit into from
Sep 26, 2021
Merged

pantheon.gala: fix session crash when taking screenshots with mutter 3.38 #139491

merged 1 commit into from
Sep 26, 2021

Conversation

bobby285271
Copy link
Member

@bobby285271 bobby285271 commented Sep 26, 2021 •
edited
Loading

Motivation for this change

Closes #139404

cc @davidak

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: pantheon The Pantheon desktop environment label Sep 26, 2021
@bobby285271 bobby285271 requested a review from davidak September 26, 2021 00:10
@bobby285271 bobby285271 mentioned this pull request Sep 26, 2021
Merged
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Sep 26, 2021
@bobby285271
Copy link
Member Author

@ofborg test pantheon

@r-rmcgibbo
Copy link

r-rmcgibbo commented Sep 26, 2021 •
edited
Loading

Result of nixpkgs-review pr 139491 at 7a038d0 run on aarch64-linux 1

22 packages built successfully:
  • monitor
  • pantheon.elementary-greeter
  • pantheon.elementary-session-settings
  • pantheon.gala
  • pantheon.switchboard-plug-a11y
  • pantheon.switchboard-plug-mouse-touchpad
  • pantheon.switchboard-plug-pantheon-shell
  • pantheon.switchboard-plug-security-privacy
  • pantheon.switchboard-with-plugs
  • pantheon.wingpanel
  • pantheon.wingpanel-applications-menu
  • pantheon.wingpanel-indicator-a11y
  • pantheon.wingpanel-indicator-bluetooth
  • pantheon.wingpanel-indicator-datetime
  • pantheon.wingpanel-indicator-keyboard
  • pantheon.wingpanel-indicator-network
  • pantheon.wingpanel-indicator-nightlight
  • pantheon.wingpanel-indicator-notifications
  • pantheon.wingpanel-indicator-power
  • pantheon.wingpanel-indicator-session
  • pantheon.wingpanel-indicator-sound
  • pantheon.wingpanel-with-indicators

Result of nixpkgs-review pr 139491 at 7a038d0 run on x86_64-linux 1

23 packages built successfully:
  • monitor
  • pantheon.elementary-greeter
  • pantheon.elementary-gsettings-schemas
  • pantheon.elementary-session-settings
  • pantheon.gala
  • pantheon.switchboard-plug-a11y
  • pantheon.switchboard-plug-mouse-touchpad
  • pantheon.switchboard-plug-pantheon-shell
  • pantheon.switchboard-plug-security-privacy
  • pantheon.switchboard-with-plugs
  • pantheon.wingpanel
  • pantheon.wingpanel-applications-menu
  • pantheon.wingpanel-indicator-a11y
  • pantheon.wingpanel-indicator-bluetooth
  • pantheon.wingpanel-indicator-datetime
  • pantheon.wingpanel-indicator-keyboard
  • pantheon.wingpanel-indicator-network
  • pantheon.wingpanel-indicator-nightlight
  • pantheon.wingpanel-indicator-notifications
  • pantheon.wingpanel-indicator-power
  • pantheon.wingpanel-indicator-session
  • pantheon.wingpanel-indicator-sound
  • pantheon.wingpanel-with-indicators

davidak
davidak approved these changes Sep 26, 2021
View reviewed changes
Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change fixes the issue.

I can not judge if the code is sane. It builds and fixes the issue, so should be good.

Thanks for the fast fix!

@davidak davidak merged commit 92ad52c into NixOS:master Sep 26, 2021
@bobby285271 bobby285271 deleted the pantheon branch September 26, 2021 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidak davidak davidak approved these changes

Assignees
No one assigned
Labels
6.topic: pantheon The Pantheon desktop environment 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pantheon: Session Crash when i try to take a screenshot
3 participants
@bobby285271 @r-rmcgibbo @davidak