-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GNOME: 40 → 41 #139144
GNOME: 40 → 41 #139144
Conversation
|
This comment has been minimized.
This comment has been minimized.
@@ -86,27 +83,25 @@ stdenv.mkDerivation rec { | |||
python3 | |||
sassc | |||
gi-docgen | |||
libxml2 # for xmllint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we make an extra output for xmllint?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, that currently is not really possible to do conveniently – build systems generally support only single bindir
per project. (Eventually, I want to have Debian-level granularity packages but that would require massive redesign of Meson and porting the affected projects to Meson.) Though, I wonder if we should explicitly list the outputs used (e.g. libxml2.bin
here) – it used to be that way in the past.
, withIntrospection ? stdenv.buildPlatform == stdenv.hostPlatform | ||
, vala | ||
, withVala ? stdenv.buildPlatform == stdenv.hostPlatform |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be one input called crossCompile or similar?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously, stdenv.isCross
was used but the cross people switched to this.
}; | ||
|
||
meta = { | ||
description = "C++ wrappers for ATK accessibility toolkit"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing maintainer
I'd like to thank you for this work. I've given it just 15 minutes so far, but what I see seems to work fine, good enough to write this comment and beyond. |
Yeah, and probably makes sense to update gnome extensions in the same PR. |
Rebased on top of current main branch and had an issue with GNOME Tracker during the
|
Weird, that does not look like something that should fail: I was not able to reproduce it so probably something transient. |
Disabled the checkPhase and currently compiling the rest of changes; couldn't really find a cause but will try to debug tomorrow if time permits. |
Completed all the tasks on the to do list, now only fixing hydra builds, updating extensions and testing remains. Any help appreciated. |
GTK WebKit took forever but finally booted into GNOME 41. Only diff from this branch rebased on top of the main branch is:
|
GNOME Shell 41 made the Eval command we use for NixOS tests internal so in order to be still able to use it, we need to run the shell in an unsafe mode. https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1970 https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1983 Hopefully, the test driver will eventually get better so that we will not need hacks like this forever.
Hydra jobset is sufficiently completed so I merged this. Extensions can be updated when new versions are released (feel free to open PRs for extensions you use). Many thanks to everyone who helped with the upgrading or testing. |
|
|
https://discourse.gnome.org/t/gnome-41-released/7603/1
cc @NixOS/gnome
https://github.com/NixOS/nixpkgs/projects/41
https://hydra.nixos.org/jobset/nixpkgs/gnome