Skip to content

fix: add htmlFor, email type, and remove dead serverError state in Lo…#290

Merged
Nitya-003 merged 1 commit into
Nitya-003:mainfrom
khushboo-khatoon:fix/accessibility-email-type-dead-state-loginform
Jun 18, 2026
Merged

fix: add htmlFor, email type, and remove dead serverError state in Lo…#290
Nitya-003 merged 1 commit into
Nitya-003:mainfrom
khushboo-khatoon:fix/accessibility-email-type-dead-state-loginform

Conversation

@khushboo-khatoon

Copy link
Copy Markdown
Contributor

changes Made

Fixed three issues in LoginForm.tsx related to accessibility,
mobile UX and code quality.

Issue 1 — Added htmlFor and id to labels and inputs

Labels were missing htmlFor and inputs were missing id attribute.
Screen readers could not associate label with input field.
Added htmlFor="email" and id="email" to email field.
Added htmlFor="password" and id="password" to password field.

Issue 2 — Added type="email" to email input

Email input had no type attribute so it defaulted to type="text".
Mobile users were not getting email keyboard.
Added type="email" to email input.

Issue 3 — Removed dead serverError state

serverError state was declared and set in catch block but never
used anywhere in JSX. Toast already handles error display.
Removed useState for serverError and setServerError from catch block.

✅ Contributor Checklist

  • I have tested my changes locally.
  • My code follows the Apple-level design guidelines.
  • I have updated the README if necessary.
  • (Apertre 3.0) I have added relevant badges/labels.

Closes #284


By submitting this PR, I agree to contribute my work under the MIT License.

@vercel

vercel Bot commented Jun 18, 2026

Copy link
Copy Markdown

@khushboo-khatoon is attempting to deploy a commit to the Nitya Gosain's projects Team on Vercel.

A member of the Team first needs to authorize it.

@khushboo-khatoon

Copy link
Copy Markdown
Contributor Author

hey @Nitya-003 ,

PR is now ready to review and merge ,please lemme know if any changes needed .

thank u (( :

@Nitya-003 Nitya-003 merged commit 9136b3b into Nitya-003:main Jun 18, 2026
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix : accessibility issues and dead state in LoginForm.tsx

2 participants