fix: add htmlFor, email type, and remove dead serverError state in Lo…#290
Merged
Nitya-003 merged 1 commit intoJun 18, 2026
Conversation
|
@khushboo-khatoon is attempting to deploy a commit to the Nitya Gosain's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
hey @Nitya-003 , PR is now ready to review and merge ,please lemme know if any changes needed . thank u (( : |
Nitya-003
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes Made
Fixed three issues in
LoginForm.tsxrelated to accessibility,mobile UX and code quality.
Issue 1 — Added htmlFor and id to labels and inputs
Labels were missing
htmlForand inputs were missingidattribute.Screen readers could not associate label with input field.
Added
htmlFor="email"andid="email"to email field.Added
htmlFor="password"andid="password"to password field.Issue 2 — Added type="email" to email input
Email input had no
typeattribute so it defaulted totype="text".Mobile users were not getting email keyboard.
Added
type="email"to email input.Issue 3 — Removed dead serverError state
serverErrorstate was declared and set in catch block but neverused anywhere in JSX. Toast already handles error display.
Removed
useStatefor serverError andsetServerErrorfrom catch block.✅ Contributor Checklist
Closes #284
By submitting this PR, I agree to contribute my work under the MIT License.