fix: add iframe title and fix setTimeout memory leak in SuggestionPanel#289
Merged
Nitya-003 merged 1 commit intoJun 18, 2026
Conversation
|
@khushboo-khatoon is attempting to deploy a commit to the Nitya Gosain's projects Team on Vercel. A member of the Team first needs to authorize it. |
Nitya-003
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed two issues in
SuggestionPanel.tsxrelated to accessibilityand memory leak.
Changes
Bug 1 — Added title to Spotify iframe
Spotify
<iframe>was missing atitleattribute. Screen readerscould not describe what the iframe contains to visually impaired users.
Added
title="Spotify Soundscape Player"to the iframe.Bug 2 — Fixed setTimeout memory leak in handleSaveNotes
setTimeoutinsidehandleSaveNoteswas never cleared. If usernavigates away before 1 second, component unmounts but timeout still
fires and tries to update state on unmounted component.
Moved setTimeout into a
useEffectwith proper cleanup usingclearTimeouton unmount.Files Changed
SuggestionPanel.tsxTesting
Fixes #283