Improve logging integration to NiryoRobot#15
Merged
jmottier-niryo merged 5 commits intoNiryoRobotics:masterfrom Nov 18, 2025
Merged
Improve logging integration to NiryoRobot#15jmottier-niryo merged 5 commits intoNiryoRobotics:masterfrom
jmottier-niryo merged 5 commits intoNiryoRobotics:masterfrom
Conversation
jmottier-niryo
requested changes
Nov 18, 2025
Collaborator
jmottier-niryo
left a comment
There was a problem hiding this comment.
Those are nice additions to PyNiryo's logging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes several minor improvements to the use of the logging facility by the NiryoRobot class.
Mainly it allows the user to pass a custom logger, allowing to:
stdoutwithout any formattingIt also suggest to lower the logging level of the
No new conveyor detectedmessage from ERROR to WARNING in accordance with the logging documentation definition of these levels.