fix(conversation): validate generated titles#261
Open
dom-mp wants to merge 2 commits into
Open
Conversation
Treat the auto-title transcript as untrusted data, escape transcript boundaries, and reject refusal/prose outputs before storing conversation title metadata. Fixes NimbleBrainInc#34
Expand generated-title validation to catch apology and identity-response variants, including curly-apostrophe forms like I’m sorry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #34.
The auto-title generator previously accepted the title model output directly, so if the model answered/refused instead of producing a title, that refusal text could be stored as
metadata.titleand shown in conversation lists.This PR hardens title generation by:
Testing
bun test test/unit/auto-title.test.tsbun run checkbun run format:checkbun run lint