fix(runtime): preserve OpenAI and Gemini reasoning replay#258
Merged
Conversation
Only strip older reasoning blocks for Anthropic so OpenAI and Gemini can replay provider-required reasoning/tool-call metadata intact. Fixes NimbleBrainInc#257
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #257.
OpenAI reasoning models can reject multi-tool replay when a prior
function_callis replayed without its pairedreasoningitem. NimbleBrain was applying the older-reasoning stripping optimization globally, even though that behavior was only intended for Anthropic thinking/signature bloat.This PR makes reasoning replay policy provider-aware:
thoughtSignaturedata stays intact.Testing
bun test test/unit/window.test.tsbun run checkbun run format:checkbun run lint