Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Go toolchain in Nix and bumps a wide range of module dependencies, with the primary goal of replacing the upstream BadgerDB v4 dependency with the NilFoundation fork.
- Switch Nix from
buildGo124ModuletobuildGoLatestModuleand update the vendored hash. - Remove the override for
goplsin Nix. - Bump Go directive and toolchain in
go.modand update many dependency versions, including areplaceforbadger/v4to the NilFoundation branch.
Reviewed Changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| nix/nil.nix | Switched from buildGo124Module to buildGoLatestModule, updated vendorHash, and adjusted the gopls override. |
| go.mod | Changed go directive and added toolchain, replaced BadgerDB import, and bumped numerous module versions. |
Comments suppressed due to low confidence (2)
nix/nil.nix:81
- [nitpick] The
goplspackage is no longer wrapped withoverrideBuildGoModule, which the other Go tools use to enforce thebuildGoLatestModulebuilder. Consider reapplyingoverrideBuildGoModuletogoplsto maintain a consistent Go version and build flags.
gopls
go.mod:3
- The
godirective typically specifies only major and minor versions (e.g.,go 1.24). Using a patch version like1.24.0is unconventional and may not be recognized; consider reverting this togo 1.24.
go 1.24.0
Contributor
|
Why did biome files change? |
Contributor
Author
New major version of biome is delivered with new nixpkgs version |
Just regular update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch updates dependencies in general but the main change is updating badgerdb to this branch: https://github.com/NilFoundation/badger/tree/nil