-
Notifications
You must be signed in to change notification settings - Fork 41
add permissionless lending features #634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
KevinMomanyi
wants to merge
14
commits into
NilFoundation:main
Choose a base branch
from
KevinMomanyi:lendingpoolfactory
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
d9aa3f4
add permissionless lending features
KevinMomanyi d27980a
GlobalLedger fuctions
KevinMomanyi f2e698e
add changes to the code
KevinMomanyi 95c6283
add changes to code
KevinMomanyi 26a6306
add missing functionalities to the code
KevinMomanyi d6900f6
add missing functionalities to the contracts
KevinMomanyi 323c89e
chore: switch to pnpm and update dependencies
KevinMomanyi 09f87d3
chore: remove package-lock.json after switching to pnpm
KevinMomanyi b7bf558
Added asyncDeploy with asyncCall and role-based access in GlobalLedger
KevinMomanyi 995a7c0
Initial commit: Lending protocol with asyncDeploy and niljs integration
KevinMomanyi 4c847d2
Updated LendingPoolFactory to use Nil.asyncCall for cross-shard inter…
KevinMomanyi 52a13ab
Add INilAsync.sol, modify LendingPoolFactory.sol, and update deploy a…
KevinMomanyi 996a70f
Refactor deployLendingPool.ts with type safety, event decoding, and t…
KevinMomanyi e1973e0
Fix: Remove asyncCall return check in LendingPoolFactory
KevinMomanyi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| // SPDX-License-Identifier: UNLICENSED | ||
| pragma solidity ^0.8.28; | ||
|
|
||
| import "./LendingPool.sol"; | ||
| import "@nilfoundation/smart-contracts/contracts/Nil.sol"; | ||
|
|
||
| /// @title LendingPoolFactory | ||
| /// @dev Deploys LendingPool contracts across shards and registers them in GlobalLedger | ||
| contract LendingPoolFactory { | ||
| address public globalLedger; | ||
| uint8 public globalLedgerShardId; | ||
| address public interestManager; | ||
| address public oracle; | ||
| TokenId public usdt; | ||
| TokenId public eth; | ||
|
|
||
| uint8 public shardCounter; | ||
| uint256 public saltCounter; //added for uniqueness in deployments | ||
|
|
||
| event LendingPoolDeployed(address pool, uint8 shardId, address owner); | ||
|
|
||
| constructor( | ||
| address _globalLedger, | ||
| uint8 _globalLedgerShardId, | ||
| address _interestManager, | ||
| address _oracle, | ||
| TokenId _usdt, | ||
| TokenId _eth | ||
| ) { | ||
| globalLedger = _globalLedger; | ||
| globalLedgerShardId = _globalLedgerShardId; | ||
| interestManager = _interestManager; | ||
| oracle = _oracle; | ||
| usdt = _usdt; | ||
| eth = _eth; | ||
| shardCounter = 0; | ||
| saltCounter = 0; | ||
| } | ||
|
|
||
| function deployLendingPool() external { | ||
| bytes memory constructorArgs = abi.encode( | ||
| globalLedger, | ||
| interestManager, | ||
| oracle, | ||
| usdt, | ||
| eth, | ||
| msg.sender | ||
| ); | ||
|
|
||
| bytes memory bytecode = bytes.concat( | ||
| type(LendingPool).creationCode, | ||
| constructorArgs | ||
| ); | ||
|
|
||
| // Deploy the LendingPool contract to the next shard using salt for uniqueness | ||
| address poolAddress = Nil.asyncDeploy( | ||
| shardCounter, | ||
| msg.sender, | ||
| address(0), | ||
| 0, | ||
| 0, | ||
| 0, | ||
| bytecode, | ||
| saltCounter //dynamic salt value | ||
| ); | ||
|
|
||
| //increment salt counter to avoid reuse | ||
| unchecked { | ||
| saltCounter++; | ||
| } | ||
|
|
||
| Nil.asyncCall( | ||
| globalLedgerShardId, | ||
| address(0), | ||
| globalLedger, | ||
| 0, | ||
| 0, | ||
| 0, | ||
| abi.encodeWithSignature( | ||
| "registerLendingPool(address)", | ||
| poolAddress | ||
| ), | ||
| 0 | ||
| ); | ||
|
|
||
| emit LendingPoolDeployed(poolAddress, shardCounter, msg.sender); | ||
|
|
||
| shardCounter = (shardCounter + 1) % 4; // Cycle through 4 shards | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,36 +1,31 @@ | ||
| import "@nomicfoundation/hardhat-chai-matchers"; | ||
| import "@nomicfoundation/hardhat-ignition-ethers"; | ||
| import "@nomicfoundation/hardhat-ethers"; | ||
| import "@nomicfoundation/hardhat-ignition-ethers"; | ||
| import "@typechain/hardhat"; | ||
| import "@nomicfoundation/hardhat-toolbox"; | ||
| import "@nomiclabs/hardhat-ethers"; | ||
|
|
||
|
|
||
| import * as dotenv from "dotenv"; | ||
| import type { HardhatUserConfig } from "hardhat/config"; | ||
|
|
||
| // Import niljs (correct scoped package) | ||
| import "@nilfoundation/niljs"; | ||
|
|
||
| import "./task/run-lending-protocol"; | ||
|
|
||
| dotenv.config(); | ||
| dotenv.config(); // Load .env variables | ||
|
|
||
| const config: HardhatUserConfig = { | ||
| ignition: { | ||
| requiredConfirmations: 1, | ||
| }, | ||
| defaultNetwork: "nil", | ||
| solidity: { | ||
| version: "0.8.28", // or your desired version | ||
| version: "0.8.28", // Match your Solidity version | ||
| settings: { | ||
| viaIR: true, // needed to compile router | ||
| optimizer: { | ||
| enabled: true, | ||
| runs: 200, | ||
| }, | ||
| }, | ||
| }, | ||
| networks: { | ||
| nil: { | ||
| url: process.env.NIL_RPC_ENDPOINT, | ||
| accounts: process.env.PRIVATE_KEY ? [process.env.PRIVATE_KEY] : [], | ||
| }, | ||
| }, | ||
| }; | ||
|
|
||
| export default config; | ||
| export default config; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the deployment of the contract, there should be a function which calls the globalLedger to register the lending pool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well noted Sir, I will make changes