chore: v3 migration phase 2 fork test#1495
Open
shark0der wants to merge 2 commits intorelease-candidatefrom
Open
chore: v3 migration phase 2 fork test#1495shark0der wants to merge 2 commits intorelease-candidatefrom
shark0der wants to merge 2 commits intorelease-candidatefrom
Conversation
…ion builder json for safe
shark0der
force-pushed
the
chore/v3-migration-phase-2-fork-test
branch
from
7967819 to
4b288d4
Compare
rackstar
reviewed
Oct 29, 2025
| // require('../../scripts/v3-migration/push-assessment-stake'); | ||
| // require('../../scripts/v3-migration/push-assessment-rewards'); | ||
|
|
||
| it('should run phase 2: migrate members', async function () { |
Contributor
There was a problem hiding this comment.
should we skip this part as well as its executed?
rackstar
reviewed
Oct 29, 2025
Comment on lines
+360
to
+370
| const limitOrdersImplementation = await deployContract('LimitOrders', [ | ||
| addresses.NXMToken, | ||
| addresses.wETH, | ||
| '0xA2dB05Ab09b00725f0C0327df6EFcbdA3F584C97', // internal solver | ||
| ]); | ||
|
|
||
| const stakingProductsImplementation = await deployContract('StakingProducts', [ | ||
| addresses.Cover, | ||
| addresses.StakingPoolFactory, | ||
| ]); | ||
|
|
Contributor
There was a problem hiding this comment.
Base automatically changed from
audit/governance-and-assessments-august-2025
to
release-candidate
October 30, 2025 12:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifies fork test to use deployed contract and generates transaction builder json for safe