Merged
Conversation
📝 WalkthroughWalkthroughUpdated the IPFS API endpoint version in the product metadata build script from v1 to v2. The change modifies the URL path used to fetch product metadata via IPFS hash while maintaining existing fetch and processing logic. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
✨ Simplify code
📝 Coding Plan
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@scripts/build-products.js`:
- Line 15: The ipfsURL helper (const ipfsURL = ipfsHash =>
`https://api.nexusmutual.io/v2/ipfs/${ipfsHash}`) may return a v2 response with
a different JSON shape; locally fetch a sample using ipfsURL(...) and validate
the body consumed by the code path that calls .then(res => res.json()), then
update the parsing logic that consumes that JSON (or adjust ipfsURL to point to
the correct endpoint) so the code handles the v2 structure (e.g., map new field
names or unwrap nested objects) before merging.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: efff8c3b-7bf2-4e67-906b-132b7c4423ef
📒 Files selected for processing (1)
scripts/build-products.js
Deploying sdk with
|
| Latest commit: |
1a8b6de
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://05a2d04c.sdk-9yp.pages.dev |
| Branch Preview URL: | https://chore-update-ipfs-url.sdk-9yp.pages.dev |
shark0der
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update ipfs url to v2
Testing
Tested the build locally
Checklist
Summary by CodeRabbit