Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results39 tests 38 ✅ 2s ⏱️ Results for commit 13560d8. ♻️ This comment has been updated with latest results. |
kimyu0218
force-pushed
the
feature/#37-회원-이름-이메일-저장
branch
from
64b398d to
14ecfc0
Compare
kimyu0218
commented
Feb 3, 2025
Comment on lines
+41
to
+57
| private SocialAccount createSocialAccount( | ||
| final Member member, final String oauthId, final SocialProvider socialProvider) { | ||
| return SocialAccountFixture.builder() | ||
| .member(member) | ||
| .oauthId(oauthId) | ||
| .socialProvider(socialProvider) | ||
| .build(); | ||
| } | ||
|
|
||
| private AppleLoginCommand createAppleLoginCommand(String idToken, String name) { | ||
| return new AppleLoginCommand(idToken, name); | ||
| } | ||
|
|
||
| private KakaoLoginCommand createKakaoLoginCommand(String authorizationCode, String redirectUri) { | ||
| return new KakaoLoginCommand(authorizationCode, redirectUri); | ||
| } | ||
|
|
There was a problem hiding this comment.
IntelliJ 설정에서 Actions on Save를 사용하고 있는데 자동으로 포맷팅해서 메서드가 클래스 위로 올라와 버렸습니다 😭
가독성에 방해된다면 해당 옵션 끄고 원상 복귀하여 다시 커밋하겠습니다..!
Closed
1 task
NaMinhyeok
approved these changes
Feb 3, 2025
Comment on lines
+24
to
+29
| private String email; | ||
|
|
||
| private Member(final String name, final String email) { | ||
| this.name = name; | ||
| this.email = email; | ||
| } |
There was a problem hiding this comment.
pn2. 별건 아닌데 email 검증해주는건 어떤가요 ?? 아니면 email을 VO로 만들어서 써도 좋을 것 같아여 !
There was a problem hiding this comment.
이건 다른 pr에 병목이 생길 것 같아 추후에 이슈 열어서 작업해보겠습니다!
.../src/test/java/org/nexters/jaknaesocore/domain/auth/service/OauthServiceIntegrationTest.java
Show resolved
Hide resolved
Merged
pythonstrup
requested changes
Feb 4, 2025
Comment on lines
+7
to
13
| public record KakaoUserInfoResponse( | ||
| @JsonProperty("id") Long id, @JsonProperty("kakao_account") KakaoAccount kakaoAccount) { | ||
|
|
||
| @JsonProperty("id") | ||
| Long id; | ||
| @JsonIgnoreProperties(ignoreUnknown = true) | ||
| public record KakaoAccount( | ||
| @JsonProperty("name") String name, @JsonProperty("email") String email) {} | ||
| } |
Comment on lines
80
to
87
| private Member findMemberWithSocialProvider( | ||
| final String oauthId, final SocialProvider socialProvider) { | ||
| return socialAccountRepository | ||
| .findByOauthIdAndSocialProviderAndDeletedAtIsNull(oauthId, socialProvider) | ||
| .map(SocialAccount::getMember) | ||
| .filter(member -> member.getDeletedAt() == null) | ||
| .orElse(null); | ||
| } |
There was a problem hiding this comment.
pn2. filter
@Query사용해서 join을 하고,member.deletedAt is null을 검사하는 방법은 어떠신가요?- 조회 조건이 비즈니스 로직에 있어야하는 이유가 있을까요?
There was a problem hiding this comment.
체이닝으로 변경하면서 사라졌습니다!
- 지금 생각하니 쿼리 어노테이션으로 확인해도 되고
- member 삭제 시 같이 삭제되니까 social account 의 deleted at 만 확인해도 되는 것 같네요
jaknaeso-core/src/main/java/org/nexters/jaknaesocore/domain/auth/service/OauthService.java
Outdated
Show resolved
Hide resolved
Comment on lines
+24
to
+29
| private String email; | ||
|
|
||
| private Member(final String name, final String email) { | ||
| this.name = name; | ||
| this.email = email; | ||
| } |
.../src/test/java/org/nexters/jaknaesocore/domain/auth/service/OauthServiceIntegrationTest.java
Show resolved
Hide resolved
pythonstrup
reviewed
Feb 4, 2025
jaknaeso-core/src/main/java/org/nexters/jaknaesocore/domain/auth/service/OauthService.java
Outdated
Show resolved
Hide resolved
애플은 최초 로그인할 때만 name 값을 전달하므로 로그인 시엔 email만 업데이트 한다
pythonstrup
reviewed
Feb 4, 2025
jaknaeso-core/src/main/java/org/nexters/jaknaesocore/domain/auth/service/OauthService.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 개요
소셜 로그인 시 회원 이름 및 이메일 저장
작업 사항
kakao_account의name,email도 받아오도록 수정