Updated react-form-validator-core to 2.0.1, removing old context API #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
I have a project where I still use MUI v5, would like to update this so that it resolves npm warnings that appear when installing this, since I am using React 17, where old context API is no longer supported.
Saw that the changes from 1.1.2 -> 2.0.1 is only the context api removal, so it should still be compatible with the same dependencies (react 17 or 18, mui5, etc.). Open to modifying the versioning to be a minor one in case this is breaking for react@<17 users
This shouldn't be merged as is, since master is on v4.0.1, but would appreciate if you created a branch for v3.0.1 on which to merge in, and then publish an update to the package.
Thanks in advance! Happy to make any changes on this to allow merging.