Refactor: centralise critique module, switch to config.json, add provider/model config, concurrency and agent profiles#1
Open
justinlietz93 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
critique_modulepackage and standardise on a single JSON configuration to simplify deployment and provider configuration.Description
src/critique_moduleand updated imports across the codebase to use the new package (examples:content_assessor,council_orchestrator,reasoning_agent,output_formatter,pipeline_input, etc.).critique_module.config_loaderand updatedconfig.jsonaddinganthropicconfig,agent_profiles, and aconcurrency.max_parallel_callsoption, while removingconfig.yamland the oldsrc/config_loader.py.providers.model_configfor centralised model/provider configuration access, updated provider clients (openai,gemini,anthropic/claude) to resolve models fromconfig.jsonand raise clear errors when models are not configured, and adjusted the provider call paths to use these accessors.asynciosemaphores, and added logic to build per-agent API configurations via_build_agent_configand_resolve_agent_providerincouncil_orchestrator.src/__main__.pymodule entrypoint and a new CLI utilitysrc/arxiv/cf_loader.pyfor indexing internal PDF corpora into the ArXiv vector store.pipeline_inputand config loader paths and removed obsolete React context files and the legacyconfig_loadermodule.Testing
pytest -qand all tests passed.flake8and no style errors were reported.python -m src.syncretic_catalyst.thesis_builderwith a mocked config and it completed the agent scheduling portion without runtime exceptions.Codex Task