Skip to content

fixed legacy optimizer issue #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixed legacy optimizer issue #42

wants to merge 1 commit into from

Conversation

@fanhui3
Copy link

@fanhui3 fanhui3 commented Apr 26, 2023 •
edited
Loading

Hi Florian,

I have fixed issue #38. The model training component should work nicely now. Hope to work with you in the future.

Best regards,
Johnny
[email protected]

FYI-PSA
FYI-PSA approved these changes Jun 23, 2023
View reviewed changes
Copy link

@FYI-PSA FYI-PSA left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and does indeed fix the legacy optimizer, alongside some formatting changes.

Someone should probably merge to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@FYI-PSA FYI-PSA FYI-PSA approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fanhui3 @FYI-PSA