Skip to content

chore: improve contributor experience (docs/scaffold/CODEOWNERS/stale)#36

Merged
NeuZhou merged 4 commits intomasterfrom
chore/contributor-experience
Apr 13, 2026
Merged

chore: improve contributor experience (docs/scaffold/CODEOWNERS/stale)#36
NeuZhou merged 4 commits intomasterfrom
chore/contributor-experience

Conversation

@NeuZhou
Copy link
Copy Markdown
Owner

@NeuZhou NeuZhou commented Apr 13, 2026

Improvements for contributor experience as the repo starts receiving community PRs.

Changes

Fixes (stale/incorrect docs)

  1. CONTRIBUTING.md — clone URL and issue links still pointed to finclaw → fixed to stratevo
  2. SECURITY.md — version table updated: added 6.x.x (supported), 5.x.x (security-only)

Enhancements

  1. Scaffold auto-placementstratevo scaffold factor now auto-detects the repo root and places source in stratevo/factor_registry/builtin/ and tests in tests/ (previously dumped both in CWD, which caused PR feat: implement VWAP factor (#18) #23 to put files in the wrong location)
  2. CODEOWNERS — auto-assigns @NeuZhou as reviewer on all PRs, with path-specific ownership for sensitive areas (evolution, trading, CI)
  3. Stale bot — marks issues/PRs stale after 30 days, auto-closes after 14 more days. Exempts pinned/priority/in-progress labels.
  4. CI note for fork contributors — added note in CONTRIBUTING.md about first-time fork PR CI approval requirement

Remaining (needs GitHub UI)

  • Fork PR CI approval setting: Settings > Actions > General > "Fork pull request workflows" > change to "Require approval for first-time contributors"

Testing

  • All 26 scaffold tests pass
  • Lint clean

NeuZhou added 4 commits April 13, 2026 05:12
…cialDataSplitter + align sandbox test exceptions

- Add MomentumAdapter to stratevo.strategies.__init__ (was in combiner.py but not exported)
- Add ModelSelector, PredictionTracker, FinancialDataSplitter to stratevo.ml.__init__
- Security sandbox tests: add ValueError to expected exceptions (sandbox raises ValueError for forbidden calls)
- Fix CONTRIBUTING.md: finclaw → stratevo in clone URL and issue links
- Fix SECURITY.md: update supported versions (add 6.x.x, 5.x.x security-only)
- Scaffold: auto-place factor source in stratevo/factor_registry/builtin/ and tests in tests/
- Add CODEOWNERS for auto-assigned PR reviews
- Add stale bot workflow (30 days stale, 14 days to close)
- Add note about first-time fork contributor CI approval
@NeuZhou NeuZhou merged commit 76ee77a into master Apr 13, 2026
3 checks passed
@NeuZhou NeuZhou deleted the chore/contributor-experience branch April 13, 2026 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant