Skip to content

Added OPT IN For SMS #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ravneetsingh1224 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added OPT IN For SMS #571

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/templates/customer/edit_account/template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,15 @@ <h2 name="contact" id="contact">Contact Information</h2>
<label for="phone">Phone number</label><span class="text-danger">*</span>
<input class="form-control" type="text" name="phone" id="phone" size="50" value="[@phone@]">
</div>
[% if [@toggle:ecommerce.sms_marketing_feature@] %]
Copy link
Contributor

@netonessa netonessa Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can't use feature toggles in webshop templates because they should not be long-term

Copy link
Contributor

@netonessa netonessa Sep 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you really want the conditional it should be

[% if [@config:ecommerce.sms_marketing_feature@] || [@opt_in_sms@] %]

<div class="form-group">
<label>
<input type='checkbox' id="subscribe_sms" [%if [@opt_in_sms@]%]checked[%/if%]>
<input type="hidden" name="opt_in_sms" value="[@opt_in_sms@]">
Subscribe to SMS notifications
</label>
</div>
[%/if%]
<div class="form-group">
<label for="fax">Fax number</label>
<input class="form-control" type="text" name="fax" id="fax" size="50" value="[@fax@]">
Expand Down