Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Test Case Names for Improved CI/CD Debugging #663

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

AnkushinDaniil
Copy link
Contributor

Add Test Case Names for Improved Debugging

This PR enhances test readability and debugging in rpc/call_test.go by adding names to test cases. Previously, tests would panic on line 114 without showing the test case name, making it difficult to identify the failing case in CI/CD logs.

Changes

  • Introduced a name field in the testSetType struct.
  • Assigned names to each test case in testSet.
  • Wrapped test execution in t.Run(name, func(t *testing.T) {...}) to provide clear subtest names in logs.

Copy link
Collaborator

@thiagodeev thiagodeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AnkushinDaniil!

@thiagodeev thiagodeev merged commit 3983286 into NethermindEth:main Feb 11, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants