Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix outdated documentation links #659

Merged
merged 7 commits into from
Feb 5, 2025

Conversation

youyyytrok
Copy link
Contributor

Hey! I’ve updated some outdated links in account.go and hash.go to point to the latest Starknet documentation. Some of the previous links referred to deprecated or renamed sections—now everything is correct.

Copy link
Collaborator

@thiagodeev thiagodeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @youyyytrok! Thank you.
Please review the links for correctness.

account/account.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@thiagodeev thiagodeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are also other mistakes regarding the links. Please take a look at each link again

account/account.go Outdated Show resolved Hide resolved
@youyyytrok
Copy link
Contributor Author

Hi @thiagodeev Check pls

@youyyytrok youyyytrok requested a review from thiagodeev February 4, 2025 13:38
Copy link
Collaborator

@thiagodeev thiagodeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @youyyytrok. Just one more thing before merging

hash/hash.go Outdated Show resolved Hide resolved
@youyyytrok youyyytrok requested a review from thiagodeev February 4, 2025 17:16
@thiagodeev thiagodeev merged commit 0cf2869 into NethermindEth:main Feb 5, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants