Optimize discv5 #10081
Merged
Optimize discv5 #10081
+42
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flcl42
force-pushed
the
optimize-discv5
branch
from
2e6c446 to
de8961f
Compare
flcl42
requested review from
AnkushinDaniil,
ak88,
benaadams,
deffrian,
emlautarom1 and
marcindsobczak
… into optimize-discv5
benaadams
approved these changes
Jan 6, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes the discv5 discovery protocol by updating the Lantern.Discv5 package from preview.6 to preview.7, implementing allocation optimizations through ENR deduplication, and refactoring various aspects of the discovery code.
Key changes:
- Updates Lantern.Discv5.WireProtocol package to version 1.0.0-preview.7
- Refactors node discovery logic with improved variable naming and code patterns
- Modifies logging levels and async operations in the discovery handler
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Directory.Packages.props | Updates Lantern.Discv5.WireProtocol package version to preview.7 |
| src/Nethermind/Nethermind.Runner/packages.lock.json | Updates lock file with new package versions and transitive dependencies |
| src/Nethermind/Nethermind.Runner/configs/base-sepolia.json | Fixes trailing whitespace formatting |
| src/Nethermind/Nethermind.Network.Discovery/Discv5/NettyDiscoveryV5Handler.cs | Updates copyright year, changes logging levels, and modernizes code style |
| src/Nethermind/Nethermind.Network.Discovery/Discv5/DiscoveryV5App.cs | Refactors discovery logic with improved naming, optimizes allocations, and changes async patterns |
src/Nethermind/Nethermind.Network.Discovery/Discv5/NettyDiscoveryV5Handler.cs
Show resolved
Hide resolved
src/Nethermind/Nethermind.Network.Discovery/Discv5/NettyDiscoveryV5Handler.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Network.Discovery/Discv5/DiscoveryV5App.cs
Outdated
Show resolved
Hide resolved
LukaszRozmej
reviewed
Jan 6, 2026
src/Nethermind/Nethermind.Network.Discovery/Discv5/DiscoveryV5App.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Network.Discovery/Discv5/DiscoveryV5App.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Network.Discovery/Discv5/DiscoveryV5App.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Network.Discovery/Discv5/NettyDiscoveryV5Handler.cs
Outdated
Show resolved
Hide resolved
LukaszRozmej
approved these changes
Jan 6, 2026
marcindsobczak
approved these changes
Jan 7, 2026
flcl42
force-pushed
the
optimize-discv5
branch
from
571373d to
5045803
Compare
stdevMac
pushed a commit
that referenced
this pull request
Jan 8, 2026
* Update schema * Fix schema * No need in type cast * Use improved discv5; refactor * Update PierTwo.Lantern.Discv5.WireProtocol * Less errors * Pooled
stdevMac
pushed a commit
that referenced
this pull request
Jan 9, 2026
* Update schema * Fix schema * No need in type cast * Use improved discv5; refactor * Update PierTwo.Lantern.Discv5.WireProtocol * Less errors * Pooled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?