Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e #2407

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Fix e2e #2407

wants to merge 8 commits into from

Conversation

AnkushinDaniil
Copy link
Contributor

@AnkushinDaniil AnkushinDaniil commented Jan 29, 2025

This pull request introduces changes to the handling of L2 gas and the addition of versioning for RPC methods in the project. The most significant updates include the removal of L2 gas fields, the introduction of versioning for RPC methods, and adjustments to the fee estimation process. Below are the key changes grouped by theme:

Removal of L2 Gas Fields:

  • Removed L2Gas field from the DataAvailability struct in core/transaction.go.
  • Removed L2Gas field handling in adaptExecutionResources functions in adapters/core2p2p/receipt.go and adapters/p2p2core/receipt.go. [1] [2]

RPC Method Versioning:

  • Added versioning constants V0_7 and V0_8 in rpc/handlers.go.
  • Introduced version-specific RPC methods in rpc/block.go and rpc/handlers.go, such as BlockWithTxHashesV0_7, BlockWithTxsV0_7, and BlockWithReceiptsV0_7. [1] [2] [3]

Fee Estimation Adjustments:

  • Removed FeeEstimateV0_7 struct and integrated versioning into the FeeEstimate struct in rpc/estimate_fee.go. [1] [2]
  • Updated the EstimateFeeV0_7 and EstimateMessageFeeV0_7 methods to use the new versioning approach. [1] [2]

Test Updates:

  • Modified tests in rpc/block_test.go and rpc/estimate_fee_pkg_test.go to accommodate the changes in fee estimation and RPC method versioning. [1] [2] [3]

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 72.02797% with 40 lines in your changes missing coverage. Please review.

Project coverage is 74.22%. Comparing base (1caf86f) to head (94cf299).

Files with missing lines Patch % Lines
rpc/block.go 12.50% 21 Missing ⚠️
rpc/simulation.go 50.00% 11 Missing and 1 partial ⚠️
rpc/estimate_fee.go 86.66% 4 Missing ⚠️
rpc/transaction.go 92.85% 2 Missing ⚠️
rpc/handlers.go 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2407      +/-   ##
==========================================
- Coverage   74.41%   74.22%   -0.19%     
==========================================
  Files         113      113              
  Lines       13016    13088      +72     
==========================================
+ Hits         9686     9715      +29     
- Misses       2592     2632      +40     
- Partials      738      741       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AnkushinDaniil AnkushinDaniil marked this pull request as ready for review January 29, 2025 08:50
@AnkushinDaniil AnkushinDaniil enabled auto-merge (squash) January 29, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant