Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update blockifier #2397

Merged
merged 44 commits into from
Feb 11, 2025
Merged

Update blockifier #2397

merged 44 commits into from
Feb 11, 2025
+4,491 −1,601

Conversation

AnkushinDaniil
Copy link
Contributor

@AnkushinDaniil AnkushinDaniil commented Jan 24, 2025 •
edited
Loading

This pull request includes changes to update the blockifier version.

@AnkushinDaniil AnkushinDaniil added VM dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Jan 24, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 24, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 77.63713% with 53 lines in your changes missing coverage. Please review.

Project coverage is 73.60%. Comparing base (81bd135) to head (936ec1f).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
rpc/v7/trace.go 61.81% 17 Missing and 4 partials ⚠️
rpc/v8/trace.go 72.50% 9 Missing and 2 partials ⚠️
rpc/v7/simulation.go 41.66% 7 Missing ⚠️
rpc/v6/simulation.go 50.00% 4 Missing ⚠️
rpc/v6/trace.go 55.55% 4 Missing ⚠️
node/throttled_vm.go 50.00% 2 Missing and 1 partial ⚠️
rpc/v8/simulation.go 96.90% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2397      +/-   ##
==========================================
+ Coverage   73.36%   73.60%   +0.23%     
==========================================
  Files         142      142              
  Lines       17065    17181     +116     
==========================================
+ Hits        12520    12646     +126     
+ Misses       3672     3656      -16     
- Partials      873      879       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AnkushinDaniil AnkushinDaniil requested a review from cicr99 January 24, 2025 19:23
@rianhughes rianhughes mentioned this pull request Jan 29, 2025
Open
rianhughes
rianhughes reviewed Jan 29, 2025
View reviewed changes
rianhughes
rianhughes reviewed Jan 29, 2025
View reviewed changes
rianhughes
rianhughes reviewed Jan 29, 2025
View reviewed changes
rianhughes
rianhughes reviewed Jan 29, 2025
View reviewed changes
rianhughes
rianhughes reviewed Jan 29, 2025
View reviewed changes
rianhughes
rianhughes reviewed Jan 29, 2025
View reviewed changes
rodrigo-pino
rodrigo-pino reviewed Jan 30, 2025
View reviewed changes
Copy link
Contributor

@rodrigo-pino rodrigo-pino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round of review. Will do another pass later. Overall, everything looks good to me.

@AnkushinDaniil AnkushinDaniil force-pushed the daniil/update-blockifier-0.13.4 branch 3 times, most recently from bcbc529 to ee0a9a3 Compare January 31, 2025 12:40
rianhughes
rianhughes reviewed Jan 31, 2025
View reviewed changes
@rianhughes
Copy link
Contributor

Up to the above comments the PR ltgm

rianhughes
rianhughes reviewed Feb 3, 2025
View reviewed changes
rodrigo-pino
rodrigo-pino reviewed Feb 3, 2025
View reviewed changes
@rodrigo-pino rodrigo-pino added the High priority Needs to be solved this week or the next label Feb 3, 2025
@AnkushinDaniil AnkushinDaniil mentioned this pull request Feb 5, 2025
Closed
@AnkushinDaniil AnkushinDaniil force-pushed the daniil/update-blockifier-0.13.4 branch from 132a67b to 28c81ec Compare February 5, 2025 15:53
AnkushinDaniil and others added 20 commits February 11, 2025 13:22
@AnkushinDaniil AnkushinDaniil force-pushed the daniil/update-blockifier-0.13.4 branch from 768cbae to b4ecf78 Compare February 11, 2025 10:25
rodrigo-pino
rodrigo-pino reviewed Feb 11, 2025
View reviewed changes
rodrigo-pino
rodrigo-pino approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@rodrigo-pino rodrigo-pino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work. Looks good to me!

@AnkushinDaniil AnkushinDaniil merged commit 890993a into main Feb 11, 2025
15 checks passed
@AnkushinDaniil AnkushinDaniil deleted the daniil/update-blockifier-0.13.4 branch February 11, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rianhughes rianhughes

@rodrigo-pino rodrigo-pino

@cicr99 cicr99

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file High priority Needs to be solved this week or the next rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AnkushinDaniil @rianhughes @rodrigo-pino