Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make internal blockchain methods private #2386

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Exca-DK
Copy link
Contributor

@Exca-DK Exca-DK commented Jan 18, 2025

Closes #2257

This PR unexports private blockchain functions that rely on transactions by copying the required functions to the migration package.

Copy link

codecov bot commented Jan 18, 2025

Codecov Report

Attention: Patch coverage is 66.89655% with 48 lines in your changes missing coverage. Please review.

Project coverage is 74.53%. Comparing base (0c6508c) to head (e141ac0).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
migration/blockchain.go 61.73% 29 Missing and 15 partials ⚠️
blockchain/blockchain.go 85.00% 0 Missing and 3 partials ⚠️
migration/migration.go 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2386      +/-   ##
==========================================
- Coverage   74.69%   74.53%   -0.16%     
==========================================
  Files         110      111       +1     
  Lines       12109    12222     +113     
==========================================
+ Hits         9045     9110      +65     
- Misses       2366     2398      +32     
- Partials      698      714      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blockchain's public functions with db's transaction should be private
1 participant