Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement starknet_getStorageProof RPC #2383

Merged
merged 11 commits into from
Jan 23, 2025
Merged

Conversation

weiihann
Copy link
Contributor

Fixes #2180

Implementation differs a lot from #2194, but tests are mostly imported from there.

Note that we currently do not support historical proofs, only the latest one.

@weiihann weiihann changed the title Implement starknet_getStorageProof Implement starknet_getStorageProof RPC Jan 16, 2025
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 72.54098% with 67 lines in your changes missing coverage. Please review.

Project coverage is 74.55%. Comparing base (21f442f) to head (f800ba6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
rpc/storage.go 72.87% 34 Missing and 17 partials ⚠️
core/state_snapshot.go 0.00% 6 Missing ⚠️
sync/pending.go 0.00% 6 Missing ⚠️
core/state.go 77.77% 2 Missing ⚠️
utils/slices.go 85.71% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2383      +/-   ##
==========================================
- Coverage   74.74%   74.55%   -0.20%     
==========================================
  Files         111      111              
  Lines       12581    12792     +211     
==========================================
+ Hits         9404     9537     +133     
- Misses       2480     2536      +56     
- Partials      697      719      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rpc/storage.go Outdated Show resolved Hide resolved
utils/slices.go Outdated Show resolved Hide resolved
utils/orderedset_test.go Outdated Show resolved Hide resolved
@weiihann weiihann force-pushed the weiihann/get-storage-proof branch from 2f7a13d to 6daf85e Compare January 21, 2025 04:54
Copy link
Contributor

@IronGauntlets IronGauntlets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments, otherwise lgtm!

rpc/storage.go Outdated Show resolved Hide resolved
rpc/storage.go Outdated Show resolved Hide resolved
rpc/handlers.go Outdated Show resolved Hide resolved
utils/slices.go Outdated Show resolved Hide resolved
utils/slices.go Outdated Show resolved Hide resolved
@weiihann weiihann force-pushed the weiihann/get-storage-proof branch from a99ecad to 0c75f0b Compare January 23, 2025 06:58
utils/slices.go Outdated Show resolved Hide resolved
@weiihann weiihann force-pushed the weiihann/get-storage-proof branch from 007622e to f800ba6 Compare January 23, 2025 10:46
@weiihann weiihann merged commit 6bf445a into main Jan 23, 2025
13 checks passed
@weiihann weiihann deleted the weiihann/get-storage-proof branch January 23, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RPC08 - starknet_getStorageProof
4 participants