-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement starknet_getStorageProof
RPC
#2383
Conversation
starknet_getStorageProof
starknet_getStorageProof
RPC
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2383 +/- ##
==========================================
- Coverage 74.74% 74.55% -0.20%
==========================================
Files 111 111
Lines 12581 12792 +211
==========================================
+ Hits 9404 9537 +133
- Misses 2480 2536 +56
- Partials 697 719 +22 ☔ View full report in Codecov by Sentry. |
2f7a13d
to
6daf85e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some minor comments, otherwise lgtm!
a99ecad
to
0c75f0b
Compare
007622e
to
f800ba6
Compare
Fixes #2180
Implementation differs a lot from #2194, but tests are mostly imported from there.
Note that we currently do not support historical proofs, only the latest one.