-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nil hash validation #2296
base: main
Are you sure you want to change the base?
Add nil hash validation #2296
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2296 +/- ##
==========================================
- Coverage 74.69% 74.63% -0.07%
==========================================
Files 110 110
Lines 12109 12109
==========================================
- Hits 9045 9037 -8
- Misses 2366 2372 +6
- Partials 698 700 +2 ☔ View full report in Codecov by Sentry. |
7282cbe
to
0e92093
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
ac9e228
to
fac578b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does using buf
in this PR is improving over not using buf?
Would adding buf means an extra dependency to compile Juno successfully or just for development? Should the use of buf
be documented somewhere as dependency?
Some questions, trying to understand the code base
Because we need to
This is for development only. |
fac578b
to
2eeb323
Compare
44a85de
to
56d5310
Compare
Fix #2239
Continue #2290
Protocol Buffer Validation:
p2p/spec/common.proto
: Added import forbuf/validate/validate.proto
and added a required field validation tomessage Hash
. [1] [2]p2p/sync/client.go
: Integratedprotovalidate
for validating protocol buffer messages in therequestAndReceiveStream
function. [1] [2] [3]