Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TraceLog changes #1822

Merged
merged 27 commits into from
May 16, 2024
Merged

TraceLog changes #1822

merged 27 commits into from
May 16, 2024

Conversation

KananGiovanni
Copy link
Contributor

@KananGiovanni KananGiovanni commented Apr 12, 2024 •
edited by wojciechos
Loading

Trace log changes

closes #1767

@codecov Codecov
Copy link

codecov bot commented Apr 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 82.60870% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 75.35%. Comparing base (0bef5c9) to head (e6010b2).

Files Patch % Lines
utils/log.go 77.77% 2 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1822      +/-   ##
==========================================
- Coverage   75.36%   75.35%   -0.02%     
==========================================
  Files          97       97              
  Lines        8313     8333      +20     
==========================================
+ Hits         6265     6279      +14     
- Misses       1517     1519       +2     
- Partials      531      535       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KananGiovanni KananGiovanni requested review from a team and kirugan and removed request for a team April 12, 2024 15:15
rianhughes
rianhughes reviewed Apr 15, 2024
View reviewed changes
.golangci.yaml Outdated Show resolved Hide resolved
rianhughes
rianhughes reviewed Apr 15, 2024
View reviewed changes
.golangci.yaml Outdated Show resolved Hide resolved
rianhughes
rianhughes reviewed Apr 15, 2024
View reviewed changes
utils/log.go Outdated Show resolved Hide resolved
rianhughes
rianhughes reviewed Apr 15, 2024
View reviewed changes
utils/log_test.go Outdated Show resolved Hide resolved
rianhughes
rianhughes reviewed Apr 15, 2024
View reviewed changes
jsonrpc/server.go Outdated Show resolved Hide resolved
rianhughes
rianhughes reviewed Apr 15, 2024
View reviewed changes
jsonrpc/server.go Outdated Show resolved Hide resolved
rianhughes
rianhughes reviewed Apr 16, 2024
View reviewed changes
utils/log_test.go Outdated Show resolved Hide resolved
rianhughes
rianhughes reviewed Apr 16, 2024
View reviewed changes
utils/log_test.go Outdated Show resolved Hide resolved
rianhughes
rianhughes reviewed Apr 16, 2024
View reviewed changes
utils/network_test.go Outdated Show resolved Hide resolved
@pnowosie pnowosie requested a review from rianhughes April 24, 2024 13:12
@rianhughes rianhughes requested a review from pnowosie May 9, 2024 09:37
pnowosie
pnowosie approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@pnowosie pnowosie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

kirugan
kirugan reviewed May 16, 2024
View reviewed changes
jsonrpc/server.go Outdated Show resolved Hide resolved
kirugan
kirugan reviewed May 16, 2024
View reviewed changes
utils/log.go Outdated Show resolved Hide resolved
kirugan
kirugan reviewed May 16, 2024
View reviewed changes
utils/log.go Outdated Show resolved Hide resolved
kirugan
kirugan reviewed May 16, 2024
View reviewed changes
jsonrpc/server.go Outdated Show resolved Hide resolved
kirugan
kirugan reviewed May 16, 2024
View reviewed changes
jsonrpc/server.go Outdated Show resolved Hide resolved
@rianhughes rianhughes merged commit 3283b79 into main May 16, 2024
10 checks passed
@rianhughes rianhughes deleted the TraceLog branch May 16, 2024 12:10
@stranger80 stranger80 linked an issue May 16, 2024 that may be closed by this pull request
Add trace option to --log-level for In-Depth RPC Logging #1767
Closed
@LordGhostX LordGhostX mentioned this pull request May 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirugan kirugan kirugan approved these changes

@pnowosie pnowosie pnowosie approved these changes

@rianhughes rianhughes Awaiting requested review from rianhughes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add trace option to --log-level for In-Depth RPC Logging
4 participants
@KananGiovanni @kirugan @pnowosie @rianhughes