Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor Fq Type from
fq c0:u256
tofq c0:u384
Description
This pull request refactors the entire codebase to replace the existing
fq
type definition fromc0: u256
toc0: u384
. This change is aimed at improving the precision and compatibility of the finite field operations for the application.Details of the Change
fq
type and associated operations fromu256
tou384
.Benchmarking Update
The current end-to-end PLONK verification process benchmark stands at 7,924,389 steps. No significant performance optimizations have been applied yet, but future iterations may focus on improving efficiency.
Testing
Next Steps
Please review the changes and let me know if there are any issues or suggestions.