Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/13 fq field u384 #32

Merged
merged 12 commits into from
Jan 2, 2025
Merged

Feature/13 fq field u384 #32

merged 12 commits into from
Jan 2, 2025

Conversation

twliu-dorian
Copy link
Collaborator

Refactor Fq Type from fq c0:u256 to fq c0:u384

Description

This pull request refactors the entire codebase to replace the existing fq type definition from c0: u256 to c0: u384. This change is aimed at improving the precision and compatibility of the finite field operations for the application.

Details of the Change

  • Updated all instances of the fq type and associated operations from u256 to u384.
  • Adjusted the related arithmetic operations and utility functions to handle the larger data type.
  • Ensured compatibility with the modular arithmetic constraints used in PLONK proof verification.

Benchmarking Update

The current end-to-end PLONK verification process benchmark stands at 7,924,389 steps. No significant performance optimizations have been applied yet, but future iterations may focus on improving efficiency.

Testing

  • All unit tests have been updated to reflect the type change and pass successfully.
  • Benchmarking tools were run to ensure the correctness of the PLONK verification after the refactor.

Next Steps

  • Monitor for any edge cases or regressions introduced due to the change in type.
  • Optimize arithmetic operations if performance becomes a bottleneck.

Please review the changes and let me know if there are any issues or suggestions.

@danielntmd danielntmd merged commit c280fc9 into main Jan 2, 2025
1 check passed
danielntmd added a commit that referenced this pull request Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants