Added Fq2 functions and related changes (Only the file groups.cairo) #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielntmd
requested changes
Nov 26, 2024
There was a problem hiding this comment.
Good work, minor adjustments, looks clean (I assume they pass tests). Let's now use these group operations in the verifier. They are mainly being used in the optimal_ate_utils.cairo file. Utilize the new group operations and report the new step count from making these changes.
Comment on lines
+578
to
+581
| .next(from_u256(rhs.x.c0.c0.clone())) | ||
| .next(from_u256(rhs.x.c1.c0.clone())) | ||
| .next(from_u256(rhs.y.c0.c0.clone())) | ||
| .next(from_u256(rhs.y.c1.c0.clone())) |
There was a problem hiding this comment.
Do we need to clone here? Did we use rhs beforehand?
Comment on lines
+731
to
+735
| let fq1_x0 = from_u256(x2.c0.c0.clone()); | ||
| let fq1_x1 = from_u256(x2.c1.c0.clone()); | ||
|
|
||
| let slope_a = from_u256(slope.c0.c0.clone()); | ||
| let slope_b = from_u256(slope.c1.c0.clone()); |
Comment on lines
+835
to
+839
| let fq1_x0 = from_u256(x.c0.c0.clone()); | ||
| let fq1_x1 = from_u256(x.c1.c0.clone()); | ||
|
|
||
| let slope_a = from_u256(slope.c0.c0.clone()); | ||
| let slope_b = from_u256(slope.c1.c0.clone()); |
Comment on lines
+1092
to
+1095
| let fq1_x0 = from_u256(rhs.x.c0.c0.clone()); | ||
| let fq1_x1 = from_u256(rhs.x.c1.c0.clone()); | ||
| let fq1_y0 = from_u256(rhs.y.c0.c0.clone()); | ||
| let fq1_y1 = from_u256(rhs.y.c1.c0.clone()); |
| @@ -263,6 +275,971 @@ impl AffineOpsFqCircuit of ECOperationsCircuitFq { | |||
| } | |||
| } | |||
|
|
|||
| impl AffineOpsFq2Circuit of ECOperationsCircuitFq2{ | |||
|
|
|||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this file are included the fq2 function :