Fix config typo, replace exec(), and improve bare except clauses#15
Open
hobostay wants to merge 1 commit intoNetflix:mainfrom
Open
Fix config typo, replace exec(), and improve bare except clauses#15hobostay wants to merge 1 commit intoNetflix:mainfrom
hobostay wants to merge 1 commit intoNetflix:mainfrom
Conversation
- Fix typo: temproal_multidiffusion_stride -> temporal_multidiffusion_stride in config/quadmask_cogvideox.py (consistent with default_cogvideox.py) - Replace unsafe exec(open(...).read()) with direct subprocess call in convert_all_scenarios_for_characters.py - Replace bare except: with specific exception types: - ImportError for module imports (train.py, train_warped_noise.py, api_multi_nodes.py) - Exception for Blender/PyBullet cleanup (kubric_variable_objects.py) - (AttributeError, TypeError) for Blender node attribute copying (render_paired_videos_blender_quadmask.py) - Fix extra whitespace in ray = None assignment (api_multi_nodes.py) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config/quadmask_cogvideox.py:temproal_multidiffusion_stride→temporal_multidiffusion_stride(consistent withdefault_cogvideox.py)exec(open(...).read())with direct subprocess call inconvert_all_scenarios_for_characters.pyexcept:clauses with specific exception types across 5 files:ImportErrorfor module import failuresExceptionfor Blender/PyBullet cleanup(AttributeError, TypeError)for Blender node attribute copyingray = None→ray = NoneTest plan
default_cogvideox.pynaming conventionexec()replacement produces equivalent command invocationexceptchanges preserve original error-handling semantics🤖 Generated with Claude Code