Skip to content

Conversation

@Aatish04
Copy link

Not able to connect to dynomite if first host is down because even if another host returns the results we are not resetting "lastException" variable, we end up throwing exception.

Not able to connect to dynomite if first host is down because even if another host returns the results we are not resetting "lastException" variable, we end up throwing exception.
@ipapapa ipapapa added the bug label Jul 14, 2017
@jcacciatore
Copy link
Contributor

I recommend including a unit test for point fixes such as this.

Out of scope for this change, however, a more robust way to implement this would be to rely only on RetryPolicy instead of a special purpose variable. Unfortunately RetryPolicy does not support retrieval of the last failure (currently you can only mark that a failure occurred and get the attempts) but we should change this to facilitate getting rid of the lastException variable altogether.

Copy link
Contributor

@ipapapa ipapapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aatish04 please see @jcacciatore feedback above if you want us to proceed your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants