This repository was archived by the owner on Dec 13, 2023. It is now read-only.
Redis Authentication Support #972
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates Conductor to use changes in the
dynolibrary to connect to Redis instances requiring password authentication. It does so by parsing an optional 4th colon-delimited string fromworkflow.dynomite.cluster.hoststo set the password on the underlyingJedisclient. (shown below)I'm looking for any feedback to support getting this change merged.
See Netflix/dyno#244 for the underlying changes, included as transitive dependency with
dyno-queues:2.0.0-rc5upgrade.https://github.com/Netflix/dyno/blob/v1.6.5/dyno-jedis/src/main/java/com/netflix/dyno/jedis/JedisConnectionFactory.java#L80-L93