feat: Enhance Test data for Calculator CLI #985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeethaGadde99
requested review from
GlimmerCape,
chethana-shastry-p and
miyamuraga
as code owners
…est-data-for-Calculator-CLI # Conflicts: # build_effective_set_generator/effective-set-generator/src/test/resources/environments/cluster-01/pl-01/effective-set/deployment/pg/postgres/values/deployment-parameters.yaml
* fix: change deploy_param processing in case of collision (Netcracker#957) * chore: Update docker image tags and envgene_version for branch main [skip ci] * docs: Separate the Application/Registry Definitions processing logic into a dedicated `app_reg_def_process` job (Netcracker#750) * docs: Separate the Application/Registry Definitions processing logic into a dedicated `app_reg_def_process` job * docs: app_reg_def_process update * feat: Add tracebitity comments in effective Set and Clarify the priority of sources for Effective Set (Netcracker#789) * docs: add Traceability in the Effective Set * docs: minor * docs: minor * docs: Traceability Comments update * docs: minor * docs: minor * docs: update pipeline description (Netcracker#962) * feat: Separate the Application/Registry Definitions processing logic into a dedicated app_reg_def_process job (Netcracker#950) * chore: Update docker image tags and envgene_version for branch main [skip ci] * docs: unify-logging (Netcracker#967) * feat: 850 Deploy postfix handling for BGD cases (Netcracker#965) * chore: Update docker image tags and envgene_version for branch main [skip ci] * feat: Removed the values from pipeline_vars.env (Netcracker#968) * chore: Update docker image tags and envgene_version for branch main [skip ci] * feat: Added new separators for ENV_NAMES (Netcracker#969) * chore: Added separators to Env_Names * chore: Added new delimeters to generate env matrix script * feat: Added APP_REG_DEF_PROCESS job to Envgene Instance Pipeline (Github) (Netcracker#974) * chore: Update docker image tags and envgene_version for branch main [skip ci] * feat: Implement new pipeline parameter "ENV_INVENTORY_CONTENT" for create/replace inventory, paramsets, credentials, and resource profile overrides (Netcracker#977) Co-authored-by: popoveugene <evgenii.a.popov.qubership@gmail.com> * chore: Update docker image tags and envgene_version for branch main [skip ci] * fix: validation for inv gen job (Netcracker#984) * chore: Update docker image tags and envgene_version for branch main [skip ci] * fix: skip env def validation for ENV_INVENTORY_CONTENT * feat: Enhance Test data for Calculator CLI * feat: Enhance Test data for Calculator CLI --------- Co-authored-by: miyamuraga <198181742+miyamuraga@users.noreply.github.com> Co-authored-by: qubership-actions[bot] <qubership-actions[bot]@users.noreply.github.com> Co-authored-by: popoveugene <42543333+popoveugene@users.noreply.github.com> Co-authored-by: Dias <120464230+dysmon@users.noreply.github.com> Co-authored-by: Siva Reddy Kunduru <35566000+sivareddyit@users.noreply.github.com> Co-authored-by: Andrei Rudchenko <104736077+andyroode@users.noreply.github.com> Co-authored-by: popoveugene <evgenii.a.popov.qubership@gmail.com>
…ure/Enhance-The-Test-data-for-Calculator-CLI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Enhance Test data for Calculator CLI. For below cases
Parameter Type Preservation in Macro Resolution
1.Simple Type Resolution
2.Complex Structure Resolution
Complex nested parameter structure case is not covered in code previously. Added fix for it.
Issue
Link to the issue(s) this PR addresses (e.g.,
Fixes #123orCloses #456). If no issue exists, explain why this change is necessary.Breaking Change?
If yes, describe the breaking change and its impact (e.g., API changes, behavior changes, or required updates for users).
Scope / Project
Specify the component, module, or project area affected by this change (e.g.,
docs,actions,workflows).Testcases for cli
Implementation Notes
Provide details on how the change was implemented, including any technical considerations, trade-offs, or notable design decisions. Leave blank if not applicable.
1.Added a pure-reference shortcut in processValue to detect values of the form ${param} and resolve them directly from Binding before template rendering.
This preserves the original object type (e.g., Map, List) and prevents unintended stringification by JinJava/Groovy.
Tests / Evidence
Describe how the changes were verified, including:
Tested with instance pipeline
Additional Notes
Include any extra information, such as:
Leave blank if not applicable.