Skip to content
This repository was archived by the owner on Dec 5, 2025. It is now read-only.

feat: update Docker Security Scan workflow with improved descriptions and input handling#35

Merged
anikin-aa merged 2 commits intomainfrom
feature/security-scan
Oct 21, 2025
Merged

feat: update Docker Security Scan workflow with improved descriptions and input handling#35
anikin-aa merged 2 commits intomainfrom
feature/security-scan

Conversation

@nookyo
Copy link
Collaborator

@nookyo nookyo commented Oct 14, 2025

Docker Security Scan Workflow Enhancement

Overview

This pull request updates the GitHub Actions workflow for Docker image and source code security scanning with improved descriptions and more robust input parameter handling.

Key Changes

Workflow Metadata Improvements

  • Renamed workflow: Vulnerability ScanDocker Security Scan
  • Removed redundant run-name to simplify the interface
  • Cleaned up duplicate comments in the file header

Enhanced Parameter Descriptions

  • image: Clarified description - "Docker image (for 'docker' target). By default ghcr.io/<owner>/<repo>:latest"
  • only-high-critical: More descriptive - "Scan only HIGH + CRITICAL"
  • trivy-scan: Clarified - "Run Trivy scan"
  • grype-scan: Clarified - "Run Grype scan"

Improved Input Parameter Handling

  • Added fallback values for critical parameters:
    • target: ${{ github.event.inputs.target || 'source' }}
    • image: ${{ github.event.inputs.image || '' }}
  • Fixed reusable workflow reference: Netcrackernetcracker (lowercase)

Technical Improvements

  • Removed redundant type: string for image parameter (default behavior)
  • Enhanced file readability and structure

Benefits

  1. Better UX: More intuitive parameter descriptions for workflow users
  2. Reliability: Added fallback values to prevent workflow failures
  3. Consistency: Aligned with naming conventions
  4. Maintainability: Simplified structure without redundant code

Testing

The workflow has been tested with various input parameter combinations and demonstrates stable operation with improved edge case handling.

Impact

  • No breaking changes
  • Backward compatible
  • Improved error handling
  • Enhanced user experience

This PR aims to enhance the quality and reliability of the security scanning process within the project's CI/CD pipeline.

@anikin-aa anikin-aa merged commit 446cc3f into main Oct 21, 2025
5 of 7 checks passed
@anikin-aa anikin-aa deleted the feature/security-scan branch October 21, 2025 09:20
@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants