Closed
Conversation
jyot560
reviewed
Sep 9, 2025
Contributor
There was a problem hiding this comment.
in deployment file of dbaas-adapter-deployment.yaml, Vault-related environment variables were removed, but in the, pgskipper-dbaas-adapter the app is still trying to fetch those Vault-related environment variables and used further in code, here :
https://github.com/Netcracker/pgskipper-dbaas-adapter/blob/main/adapter/main.go#L62
please check that also
jyot560
reviewed
Sep 9, 2025
Contributor
There was a problem hiding this comment.
{{- define "patroni-core-operator.vaultEnvs" }} , please check where is this definition used?
Contributor
Author
There was a problem hiding this comment.
There are no usages of this definition.
Collaborator
|
Was done in #118 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed vault functionality from pgskipper-operator.