Skip to content

Fix pg_patroni_service_slot_cleaner_for_host func add wal_keep_size #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anikin-aa merged 3 commits into from
Nov 25, 2025
Merged

Fix pg_patroni_service_slot_cleaner_for_host func add wal_keep_size #142

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c24ba1
Fix: pg_patroni_service_slot_cleaner_for_host func add wal_keep_size
Nov 24, 2025
0fe26aa
Fix: pg_patroni_service_slot_cleaner_for_host
Nov 24, 2025
99643ec
Fix: remove wal_keep_segments
Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions build/configs/postgresql/postgresql_prepare.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,18 +88,16 @@ BEGIN
CREATE TEMPORARY TABLE pg_patroni_service_slot_cleaner_passwd_output (tt_id serial PRIMARY KEY NOT NULL, command_output text );
COPY pg_patroni_service_slot_cleaner_passwd_output (command_output) FROM PROGRAM 'strings /proc/1/environ | sed -n "s/^PG_ROOT_PASSWORD=\(.*\)/\1/p"';

-- get current wal_keep_segments value and determine allowed_slot_delay
-- get current wal_keep_size value and determine allowed_slot_delay
IF ud_allowed_slot_delay < 0 THEN
SELECT INTO allowed_slot_delay setting FROM pg_settings where name='wal_keep_segments';
SELECT setting::integer INTO allowed_slot_delay FROM pg_settings where name='wal_keep_size';
ELSE
allowed_slot_delay = ud_allowed_slot_delay;
END IF;

-- check if we have pg_xlog_location_diff or not (postgresql 9.6 vs postgresql 10)
select into use_old_cmp_function exists(select * from pg_proc where proname = 'pg_xlog_location_diff');

--todo[anin] 16Mb size per WAL file is used. Honest calculation should get value from pg_settings
allowed_slot_delay := allowed_slot_delay * 16 ;
RAISE NOTICE 'allowed_slot_delay: % Mb', allowed_slot_delay;

-- perform slot cleanup for each active replica
Expand Down