Skip to content

fix(config): Update clientlibs and renderClientLibs to read extraEntries correctly #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

albertogarciaariza
Copy link

Description

This update ensures that the extraEntries are properly read and incorporated into the client library generation process.

Related Issue

Fixes #128

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • All new and existing tests passed.

@Hugoer
Copy link
Member

Hugoer commented May 16, 2025

Hi team,

Thanks again for resolving the issue with the incorrect config path.

As a follow-up, there's now a real need to change the extraEntries field from an object to an array. This change is important to better support Webpack's advanced optimization configurations—particularly when generating separate files like runtime, chunks, and enabling treeshaking.

These setups can produce multiple output entries that need to be handled in a specific order or allow duplicate keys (e.g., for splitting or grouping), which a plain object structure can't support effectively. Using an array will provide the flexibility and control needed for these use cases.

Can you please update the structure and any related logic accordingly? 💜

Let me know if any clarification is needed!

Thanks!

@Hugoer Hugoer self-requested a review May 19, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

extraEntries is defined in config.clientlibs but incorrectly read from config.postcss
3 participants