docker: restructure containerization support files into distrib/docker #2482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdmark
force-pushed
the
rdmark-docker-subdir
branch
5 times, most recently
from
34fdad1 to
d80b097
Compare
Consolidating all files that have to do with Docker into a single subdir, for discoverability and maintainability The drawback is that that you have do specify the file that docker build and docker compose should read, ex: % docker build -t netatalk:latest -f distrib/docker/netatalk.Dockerfile . % docker compose -f distrib/docker/docker-compose.yml up
By explicitly copying only what's absolutely necessary for the configuration, we save on build runtime as well as protect against future unexpected file inclusions
rdmark
force-pushed
the
rdmark-docker-subdir
branch
from
d80b097 to
ab746ae
Compare
|
andylemin
reviewed
Oct 14, 2025
|
If you think this is a misguided change then I would love to know! Are there particular files that you should should stay where they are? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidating all files that have to do with Docker into a single subdir, for discoverability and maintainability
The drawback is that that you have do specify the file that docker build and docker compose should read, ex:
Additionally, refactor meson and dockerfiles to copy only required build files over to workdir
By explicitly copying only what's absolutely necessary for the configuration, we save on build runtime as well as protect against future unexpected file inclusions