feat: add approved VikingDB knowledge service - #8
Merged
Conversation
YangYuS8
marked this pull request as ready for review
July 16, 2026 11:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
approval_status=approvedfilters into VikingDBnivora-knowledgeHTTP service with independent authenticationnivora-knowledge-evalJSONL benchmark for expected/forbidden sources and latencySecurity boundary
Nivora Core does not receive VikingDB credentials. The product Provider resolves the tenant from trusted customer context and calls the private knowledge service. Malformed, stale, draft, expired, cross-tenant, low-confidence, or incomplete results fail closed.
Validation
The final read-only CI passes:
go mod tidygofmtgo vet ./...go test -race ./...go build -trimpath ./...This validates Nivora, both evaluation CLIs, and the approved knowledge service binaries with the locked official VikingDB Retriever dependency.