Skip to content

Conversation

@jorisvilardell
Copy link
Collaborator

This pull request involves significant changes to the Docker volume management and related code cleanup. The main changes include the addition of volume definitions in the docker-compose.yml file and the removal of the ensure_volumes function and its related code from the Rust application.

Docker volume management:

  • Added volume definitions for prometheus_data, nephelios_data, registry_data, grafana_data, grafana_provisioning, and grafana_dashboard in the docker-compose.yml file.

Code cleanup:

  • Removed the ensure_volumes function and its invocation in src/main.rs. This includes the removal of the call to ensure_volumes in the main function and the corresponding import statement. [1] [2]
  • Deleted the ensure_volumes function and the NepheliosVolume struct from src/services/helpers/docker_helper.rs. [1] [2]

@jorisvilardell jorisvilardell merged commit 337fa4b into main Apr 15, 2025
1 check passed
@jorisvilardell jorisvilardell deleted the fix/nephelios-manager-binds branch April 15, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants