Add docstring for ideal_type
#2235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
force-pushed
the
mh/ideal_type
branch
from
7bae0a0 to
feea7bb
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2235 +/- ##
=======================================
Coverage 88.00% 88.00%
=======================================
Files 127 127
Lines 31798 31809 +11
=======================================
+ Hits 27983 27995 +12
+ Misses 3815 3814 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SoongNoonien
approved these changes
Dec 10, 2025
lgoettgens
reviewed
Dec 10, 2025
fingolfin
commented
Dec 10, 2025
| Return the type of ideals over the given ring `R`, respectively over rings of type `T`. | ||
| """ | ||
| ideal_type(x) = ideal_type(typeof(x)) |
Member
Author
There was a problem hiding this comment.
@thofma I tried restricting this to Ring, but it seems Hecke needs ideal_type for NCRing -- namely for Hecke.AlgAssAbsOrd{StructureConstantAlgebra{QQFieldElem}, ZZRing}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from PR #2108