Skip to content

Fix Nemo#2173 #2216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joschmitt merged 2 commits into from
Nov 20, 2025
Merged

Fix Nemo#2173 #2216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92dba73
Convert to an OSCAR matrix instead of a Julia matrix
joschmitt Nov 18, 2025
1106c47
Remove unnecessary line
joschmitt Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/Solve.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,6 @@ function matrix_normal_form_type(R::Ring)
end

matrix_normal_form_type(::Field) = RREFTrait()
matrix_normal_form_type(::Matrix{Rational{BigInt}}) = FFLUTrait()

# The fflu approach is the fastest over a fraction field (see benchmarks on PR 661)
matrix_normal_form_type(::FracField) = FFLUTrait()
Expand Down
8 changes: 5 additions & 3 deletions src/generic/MatRing.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,12 @@ end
function AbstractAlgebra.can_solve_with_solution(M::MatRingElem{T}, B::MatRingElem{T}) where {T <: RingElement}
check_parent(M, B)
R = base_ring(M)
MS = MatSpaceElem{T}(R, M.entries) # convert to ordinary matrix
BS = MatSpaceElem{T}(R, B.entries)
# TODO: Once #1955 is resolved, the conversion to matrix and back to MatRingElem
# should be done better
MS = matrix(R, M.entries) # convert to ordinary matrix
BS = matrix(R, B.entries)
flag, S = can_solve_with_solution(MS, BS)
SA = MatRingElem{T}(R, S.entries)
SA = MatRingElem{T}(R, Array(S))
return flag, SA
end

Expand Down
Loading