Allow callers to inject their own HTTP client.

[danmarg]

This is necessary for AppEngine usage, where the standard HTTP client from net/http is not allowed.

[NaySoftware]

good change. but this will make some changes in the api.
so make a setclient func to set other client if needed, else the client will set to the default http

[danmarg]

Happy to do so, but just to be clear, this is a new "constructor" function (NewFcmClientWithHttp vs NewFcmClient). A SetClient func is also a reasonable approach. I dunno which is more Gothonic.

…

On Fri, Nov 17, 2017 at 4:38 PM Ahmad [Abo] Khet ***@***.***> wrote: good change. but this will make some changes in the api. so make a setclient func to set other client if needed, else the client will set to the default http — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#15 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AB1viwReJgO2S5OZ1mn_1OZvP1VnlfCUks5s3ahwgaJpZM4QdSUt> .

[NaySoftware]

I'll re-review the current commit and will discuss it :)
Thank you very much

[NaySoftware]

BTW, star the repo :)

[danmarg]

No worries. I don't mind changing it, either, if you prefer an injector--just wanted to make sure you saw how it works now. Let me know your preference.

…

On Fri, Nov 17, 2017 at 7:34 PM Ahmad [Abo] Khet ***@***.***> wrote: I'll re-review the current commit and will discuss it :) Thank you very much — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#15 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AB1vi9OfysKBArylgs_YSgZ9TEWRHuvgks5s3dGngaJpZM4QdSUt> .