renamed editBox coponent to MentorEditLearningObj#107
Open
SULAIMAN-100 wants to merge 122 commits into
Open
Conversation
fixed image issue on login page
SULAIMAN-100
requested review from
AltomHussain,
NawalC,
cgkr and
petemcfarlane
petemcfarlane
approved these changes
Feb 1, 2021
petemcfarlane
left a comment
petemcfarlane
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, much clearer name 👍
Comment on lines
+217
to
+224
| /* | ||
| .skills-container .edit-btn:not A:hover { | ||
| border-radius: 4px; | ||
| color: white; | ||
| text-decoration: none; | ||
| border-bottom: 1px solid whites; | ||
| text-align: center; | ||
| } | ||
| } */ |
Collaborator
There was a problem hiding this comment.
Is it worth deleting this, rather than simply commenting out?
Add initial deploy-staging circleci workflow
Refactor mentor edit
Refactor add form
used in header.js also created logout endpoin in api.js)
Cleared all logs and sorted the security of the mentorEditLearningObj…
Deselect btns
Highlight student
fixing heroku error
still trying to fix staging link id undefined
Addlearningobjective
Deselect btns
Update doc md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ued code lines
Before sending your Pull Request, be sure to check that you are making the pull request from your branch to the dev branch! Please do not try to push directly into branches on the main repo.
renamed editBox coponent to MentorEditLearningObj and cleaned some unused code lines