Refactor add form#103
Open
AltomHussain wants to merge 3 commits into
Open
Conversation
AltomHussain
requested review from
Iman-feisali,
NawalC,
SULAIMAN-100,
cgkr and
petemcfarlane
petemcfarlane
approved these changes
Jan 25, 2021
petemcfarlane
left a comment
petemcfarlane
left a comment
Collaborator
There was a problem hiding this comment.
Looks great! Just a pesky console.log added - seems a shame since you're removing them in one of the commits!
| <option>Select a skill</option> | ||
| {skills.map((skill) => ( | ||
| <option value={skill}>{skillLabel(skill)}</option> | ||
| ))} |
NawalC
approved these changes
Jan 25, 2021
SULAIMAN-100
approved these changes
Jan 31, 2021
cgkr
reviewed
Feb 1, 2021
| // import fakeData from "../fakeData.json"; | ||
| import AddForm from "./AddForm"; | ||
|
|
||
| import fakeData from "../fakeData.json"; |
Collaborator
There was a problem hiding this comment.
Seems like this is loading dummy data for testing. Is this needed here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes have you made?
Provide a short description of the changes you made and, if necessary, the reasons for these changes.
AddForm.jscomponent toLearningObjectiveAddForm.js-Removed unused code and all
console.logs