Feat/list update #19
Merged
Feat/list update #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NathanWalker I can show you the demo of the changes in a call or whatever later. The time difference from Ireland and California is 8 hours. |
| imports: [NativeScriptCommonModule, NativeScriptRouterModule], | ||
| providers: [PersonService], |
There was a problem hiding this comment.
Simpler to use providedIn: 'root' and not provide per component (leads to more confusion imho)
There was a problem hiding this comment.
For a small app, it's fine to use root. I'll make the change
apps/nativescript-starter-angular/src/app/people/people.component.html
Outdated
Show resolved
Hide resolved
apps/nativescript-starter-angular/src/app/people/people.component.html
Outdated
Show resolved
Hide resolved
… both iOS and Android
…nto feat/list-update
apps/nativescript-starter-angular/src/app/people/person.component.ts
Outdated
Show resolved
Hide resolved
apps/nativescript-starter-angular/src/app/people/person-detail.component.ts
Outdated
Show resolved
Hide resolved
apps/nativescript-starter-angular/src/app/people/person-detail.component.html
Outdated
Show resolved
Hide resolved
apps/nativescript-starter-angular/src/app/people/person-detail.component.html
Outdated
Show resolved
Hide resolved
apps/nativescript-starter-angular/src/app/people/person-detail.component.html
Show resolved
Hide resolved
apps/nativescript-starter-angular/src/app/people/person-detail.component.ts
Outdated
Show resolved
Hide resolved
apps/nativescript-starter-angular/src/app/people/person-detail.component.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated list - replacing with famous computer scientists in history