Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8 v11 prep #1794

Draft
wants to merge 23 commits into
base: main
Choose a base branch
from
Draft

V8 v11 prep #1794

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
a96d750
chore: Use jint for Java object ID everywhere
ptomato Apr 28, 2023
9c53587
chore: Avoid shadowing variable
ptomato May 8, 2023
f2d6cac
chore: Remove dead code from ObjectManager
ptomato May 8, 2023
29311b2
feat: Remove markingMode
ptomato May 8, 2023
8d5f8f5
chore: Remove useGlobalRefs
ptomato May 10, 2023
4ec8502
chore: Init ObjectManager::m_isolate in Init()
ptomato May 16, 2023
d7a590d
chore: Initialize ObjectManager in one phase
ptomato May 16, 2023
489100c
chore: Make some methods static
ptomato May 17, 2023
cc6fd5d
chore: Store wrapper object template instead of ctor function template
ptomato May 18, 2023
917422f
fix: NativeScript include directories in cmake file
ptomato Aug 30, 2023
e8e9dec
fix: passing wrong arguments to NativeScriptException ctor
ptomato Aug 29, 2023
016c077
fix: Populate keywords set during static initialization
ptomato Aug 30, 2023
e87074a
fix: init NativeScriptException earlier
ptomato Aug 29, 2023
e284c07
fix: move GetClassName out of ObjectManager
ptomato Aug 29, 2023
91ca870
fix: Safety check on clearing dex cache
ptomato Aug 30, 2023
c58d3ff
chore: Switch from CreationContext() to GetCreationContextChecked()
ptomato Feb 10, 2023
492dadc
chore: Set V8 flags before initializing V8
ptomato Apr 28, 2023
9a96029
chore: Use CPPGC-compatible platform
ptomato May 17, 2023
a11a490
chore: Remove unused V8 inspector sources
ptomato May 9, 2023
34d2786
chore: Remove duplicate code
ptomato May 25, 2023
18f90c4
chore: Make MetadataNode::tryGetExtensionMethodCallbackData more effi…
ptomato May 30, 2023
1843dd2
chore: Remove ObjectManager dead code
ptomato Aug 25, 2023
25338bf
chore: Avoid copy in MetadataNode::IsJavascriptKeyword
ptomato Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion test-app/app/src/main/assets/app/mainpage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ require("./tests/discardedExceptionsTest");
require("./tests/dispatchCallbacksOnUiThreadTests");
require("./tests/stringConversionTests");
require("./tests/testsForTypescript");
require("./tests/testGC");
require("./tests/testsMemoryManagement");
require("./tests/testFieldGetSet");
require("./tests/extendedClassesTests");
Expand Down
1 change: 0 additions & 1 deletion test-app/app/src/main/assets/app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
"gcThrottleTime": 500,
"memoryCheckInterval": 10,
"freeMemoryRatio": 0.50,
"markingMode": "none",
"maxLogcatObjectSize": 1024,
"forceLog": false,
"suppressCallJSMethodExceptions": false,
Expand Down
320 changes: 0 additions & 320 deletions test-app/app/src/main/assets/app/tests/testGC.js
View file
Open in desktop

This file was deleted.

5 changes: 2 additions & 3 deletions test-app/runtime/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ add_library(
src/main/cpp/AssetExtractor.cpp
src/main/cpp/CallbackHandlers.cpp
src/main/cpp/Constants.cpp
src/main/cpp/DirectBuffer.cpp
src/main/cpp/FieldAccessor.cpp
src/main/cpp/File.cpp
src/main/cpp/IsolateDisposer.cpp
Expand Down Expand Up @@ -147,13 +146,13 @@ if (OPTIMIZED_BUILD OR OPTIMIZED_WITH_INSPECTOR_BUILD)
set_target_properties(
NativeScript
PROPERTIES LINK_FLAGS -Wl,--allow-multiple-definition -Wl,--exclude-libs=ALL -Wl,--gc-sections
INTERFACE_INCLUDE_DIRECTORIES NATIVES_BLOB_INCLUDE_DIRECTORIES
INTERFACE_INCLUDE_DIRECTORIES ${NATIVES_BLOB_INCLUDE_DIRECTORIES}
)
else ()
set_target_properties(
NativeScript
PROPERTIES LINK_FLAGS -Wl,--allow-multiple-definition
INTERFACE_INCLUDE_DIRECTORIES NATIVES_BLOB_INCLUDE_DIRECTORIES
INTERFACE_INCLUDE_DIRECTORIES ${NATIVES_BLOB_INCLUDE_DIRECTORIES}
)
endif ()

Expand Down
2 changes: 1 addition & 1 deletion test-app/runtime/src/main/cpp/ArrayElementAccessor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ Local<Value> ArrayElementAccessor::ConvertToJsValue(Isolate* isolate, ObjectMana
if (elementSignature[0] == '[') {
className = Util::JniClassPathToCanonicalName(elementSignature);
} else {
className = objectManager->GetClassName(*(jobject*) value);
className = env.GetClassName(*(jobject*) value);
}

jsValue = objectManager->CreateJSWrapper(javaObjectID, className);
Expand Down
Loading