Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support to link a tld to a child IBDO for inheriting parameters #1016

Merged
merged 5 commits into from
Jan 8, 2025
Merged

Adding support to link a tld to a child IBDO for inheriting parameters #1016

merged 5 commits into from
Jan 8, 2025

Conversation

rpg36
Copy link
Collaborator

@rpg36 rpg36 commented Nov 25, 2024

No description provided.

@fbruton
Copy link
Collaborator

fbruton commented Nov 26, 2024 •
edited
Loading

To preserve the conversation history, I recommend to close this PR, open #919, rename this branch to the branch referenced by 919 and force push renamed branch.

fbruton
fbruton requested changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@fbruton fbruton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include changes in PR #919

@jpdahlke jpdahlke added this to the v8.20.0 milestone Dec 16, 2024
@jpdahlke jpdahlke added the framework This change will impact the core framework label Dec 23, 2024
@fbruton fbruton self-requested a review December 24, 2024 15:33
@jpdahlke jpdahlke added the priority This has mirrored work driving the need label Jan 7, 2025
fbruton
fbruton previously requested changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@fbruton fbruton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will reapprove with unit-tests

drivenflywheel
drivenflywheel requested changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@drivenflywheel drivenflywheel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor cleanup requested, new code needs some test coverage

src/main/java/emissary/core/BaseDataObject.java Outdated Show resolved Hide resolved
src/main/java/emissary/core/DataObjectFactory.java Show resolved Hide resolved
src/main/java/emissary/core/DataObjectFactory.java Show resolved Hide resolved
src/main/java/emissary/core/IBaseDataObject.java Outdated Show resolved Hide resolved
drivenflywheel
drivenflywheel approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@drivenflywheel drivenflywheel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the test coverage!

@jpdahlke jpdahlke merged commit 3b8a98b into NationalSecurityAgency:main Jan 8, 2025
12 checks passed
ldhardy pushed a commit to ldhardy/emissary that referenced this pull request Jan 9, 2025
@rpg36 @ldhardy
add support to link a tld to a child IBDO for inheriting parameters (N…
c4bb10d 
…ationalSecurityAgency#1016)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpdahlke jpdahlke jpdahlke approved these changes

@drivenflywheel drivenflywheel drivenflywheel approved these changes

@fbruton fbruton Awaiting requested review from fbruton

Assignees
No one assigned
Labels
framework This change will impact the core framework priority This has mirrored work driving the need
Projects
None yet
Milestone
v8.20.0
Development

Successfully merging this pull request may close these issues.
4 participants
@rpg36 @fbruton @drivenflywheel @jpdahlke